Skip to content

[JsLIGO] Bug fix: The Attributes self-pass used Make instead of MakeDefault,...

Christian Rinderknecht requested to merge rinderknecht@js_selfpass into dev

Motivation and Context

In the JsLIGO self-pass Attributes on tokens, the scanning of comments to extract attributes was using the JsLIGO lexer instanciated by reading the CLI command line of the standalone lexer, instead of the lexer for the compiler. As a consequence, the reading of the CLI would sometimes fail at runtime.


In the JsLIGO self-pass Attributes on tokens, instead of calling CLI.Make, we now call CLI.MakeDefault, which does not read the CLI, but provides default values.


  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)


Fixed bug in the lexing of JsLIGO: the CLI was incorrectly read and could lead to a runtime error.


  • If a new syntax has been introduced, put a message on slack ligo-lsp
  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports