Skip to content

CameLIGO: add support for module access in type application

Melwyn Saldanha requested to merge melwyn95@module_access_type_application into dev

Motivation and Context

Fixes #1387 (closed)

Description

There was bug in abstractor/cst-unifier for CameLIGO where type application + module access didn't get compiled correctly

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Type application for parametric types inside modules is fixed in this MR

Example

module Foo = struct
  type 'a t = Bar of 'a
  type ('a, 'b) s = 'a t
end

type ('a, 'b) baz = ('a, 'b) Foo.s

let test1 : int Foo.t = Bar 42
let test2 : (int, string) baz = test1

Result

$ ligo run test x.mligo 
Everything at the top-level was executed.
- test1 exited with value Bar (42).
- test2 exited with value Bar (42).

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by Melwyn Saldanha

Merge request reports