Skip to content
Snippets Groups Projects

JsLIGO: allow final uppercase in module path for types

Merged E. Rivas requested to merge er433/fix/jsligo_type_path into dev
All threads resolved!

Motivation and Context

Guillaume T. reported a bug w.r.t. capitalized type names inside namespaces.

Description

This MR fixes the bug by changing the JsLIGO parser to allow capitalized type variable name.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Melwyn Saldanha approved this merge request

    approved this merge request

  • E. Rivas resolved all threads

    resolved all threads

  • Laurent Canis added 2 commits

    added 2 commits

    • 6ce2b79b - Merge branch 'er433/fix/jsligo_type_path' into 'dev'
    • f77ec9da - [Bot] add changelog entry

    Compare with previous version

  • E. Rivas mentioned in commit 6ce2b79b

    mentioned in commit 6ce2b79b

  • Edited by Ligo Lang
  • E. Rivas started a merge train

    started a merge train

  • merged

  • E. Rivas mentioned in commit 279d0e0b

    mentioned in commit 279d0e0b

  • unassigned @er433

  • Please register or sign in to reply
    Loading