Skip to content
Snippets Groups Projects

Testing framework: `Rejected` return type

Merged E. Rivas requested to merge er433/fix/test-framework-fail-type into dev
All threads resolved!

Motivation and Context

The type int was always assigned to failure returned type when doing Test.transfer_to_contract.

Description

Instead of assigning type int to it, we can assign an untyped Michelson type.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by E. Rivas

Merge request reports

Merge train pipeline #874904107 passed

Merge train pipeline passed for a9b994fd

Merged by E. RivasE. Rivas 1 year ago (May 22, 2023 4:19pm UTC)

Merge details

  • Changes merged into dev with 4fb0b0b2 (commits were squashed).
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #874935691 passed

Pipeline passed for 4fb0b0b2 on dev

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rémi approved this merge request

    approved this merge request

  • E. Rivas added 1 commit

    added 1 commit

    • f5bc8c23 - refactor: remove unused storage_retreival_dummy_ty

    Compare with previous version

  • E. Rivas resolved all threads

    resolved all threads

  • E. Rivas resolved all threads

    resolved all threads

  • E. Rivas resolved all threads

    resolved all threads

  • E. Rivas enabled automatic add to merge train when the pipeline for f4058273 succeeds

    enabled automatic add to merge train when the pipeline for f4058273 succeeds

  • E. Rivas started a merge train

    started a merge train

  • merged

  • E. Rivas mentioned in commit 4fb0b0b2

    mentioned in commit 4fb0b0b2

  • unassigned @er433

  • Please register or sign in to reply
    Loading