Skip to content

Internal: replace environment for signature and do separate typing

E. Rivas requested to merge er433/typer/env-for-sig into dev

Motivation and Context

Typing each module separately was found to be slow, so we were doing a big Ast_core with all modules and then typing that.


In this MR we propose to type modules separately, and then build a big Ast_typed. The first change makes the typer (and REPL) use Ast_typed.signature as a "context" (i.e. previous defs.) instead of Environment.t. To make typing work faster, we needed to update slightly the build system, by remembering only the current signature after typing a module, and not the whole context (change in compile_file_with_deps).


  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)



  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by E. Rivas

Merge request reports