Skip to content
Snippets Groups Projects

Bug: mixing `export` with attributes

Merged E. Rivas requested to merge er433/fix/nanopass-export into dev

Motivation and Context

This comes from an issue reported by Benjamin, in which export and @entry do not interact correctly.

Description

In this MR we change the Export_declaration nanopass to generate an attribute public.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by E. Rivas

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Melwyn Saldanha approved this merge request

    approved this merge request

  • Rémi approved this merge request

    approved this merge request

  • E. Rivas resolved all threads

    resolved all threads

  • E. Rivas added 1 commit

    added 1 commit

    • 33d8d2e8 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • E. Rivas changed title from Fix: mixing export with attributes to Bug: mixing export with attributes

    changed title from Fix: mixing export with attributes to Bug: mixing export with attributes

  • E. Rivas mentioned in commit 510a7f30

    mentioned in commit 510a7f30

  • Laurent Canis added 6 commits

    added 6 commits

    Compare with previous version

  • E. Rivas enabled automatic add to merge train when the pipeline for 1f7efe95 succeeds

    enabled automatic add to merge train when the pipeline for 1f7efe95 succeeds

  • Edited by Ligo Lang
  • E. Rivas started a merge train

    started a merge train

  • E. Rivas removed this merge request from the merge train because pipeline did not succeed

    removed this merge request from the merge train because pipeline did not succeed

  • E. Rivas added this merge request to the merge train at position 3

    added this merge request to the merge train at position 3

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading