Bug: mixing `export` with attributes
Motivation and Context
This comes from an issue reported by Benjamin, in which export
and @entry
do not interact correctly.
Description
In this MR we change the Export_declaration
nanopass to generate an attribute public
.
Component
-
compiler -
website -
webide -
vscode-plugin -
debugger
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to not work as expected) -
Performance improvement (non-breaking change that improves performance) -
None (change with no changelog)
Changelog
Checklist:
-
Changes follow the existing coding style (use dune @fmt
to check). -
Tests for the changes have been added (for bug fixes / feature). -
Documentation has been updated. -
Changelog description has been added (if appropriate). -
Start titles under ## Changelog
section with #### (if appropriate). -
There is no image or uploaded file in changelog -
Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by E. Rivas
Merge request reports
Activity
assigned to @er433
- Resolved by E. Rivas
mentioned in commit 510a7f30
added 6 commits
-
33d8d2e8...a1270b8e - 4 commits from branch
dev
- 510a7f30 - Merge branch 'er433/fix/nanopass-export' into 'dev'
- cd9fa3ad - [Bot] add changelog entry
-
33d8d2e8...a1270b8e - 4 commits from branch
enabled automatic add to merge train when the pipeline for 1f7efe95 succeeds
A new deploy preview is available on Netlify at https://2540-28d84a90--ligolang.netlify.app, you can view the logs at https://app.netlify.com/sites/ligolang/deploys/6442ae5fa75498133ea29a06
Edited by Ligo Lang
Please register or sign in to reply