Skip to content

Fix bugs in `ligo publish`

Melwyn Saldanha requested to merge fix/ligo_publish into dev

Motivation and Context

This MR fixes the following bugs in ligo publish

  1. Fix handling of .ligoignore file (handle/ignore empty lines & comments # ...)
  2. Fix naming of tar-archive with package name containing unfriendly filename chars like (/)

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

For a LIGO package with name @ligo/fa

Before

$ ligo.61 publish --dry-run
==> Reading manifest... Done
==> Validating manifest file... Done
==> Finding project root... Done
==> Packing tarball... An internal error ocurred. Please, contact the developers.
(Sys_error "/tmp/@ligo/fa675f7d1.0.1: No such file or directory").

After

$ ligo publish --dry-run
==> Reading manifest... Done
==> Validating manifest file... Done
==> Finding project root... Done
==> Packing tarball... Done
    publishing: @ligo/fa@1.0.1
    === Tarball Details ===
    name:          @ligo/fa
    version:       1.0.1
    filename:      @ligo/fa-1.0.1.tgz
    package size:  36.4 kB
    unpacked size: 249.5 kB
    shasum:        a1755ccfecb90d06440aef9d0808ec1499fc22f4
    integrity:     sha512-c986ef7bc12cd[...]9b6f8c626f8fba7
    total files:   49

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by Melwyn Saldanha

Merge request reports