Skip to content

[#1658] Support getting configuration from VSCode

Motivation and Context

Related Issue(s): #1658 (closed)

Support reading the workspace configuration from the Visual Studio Code extension.

Checklist for the LIGO Language Server

  • I checked whether I need to update the README.md file for the plugin and did so if necessary
  • I checked that my changes work in Emacs, Vim, and Visual Studio Code
  • (Before merging) The commit history is squashed and prettified, and follows the Serokell commit policy, or the MR is set to squash the commits

Description

We previously ignored the configuration from VS Code. This MR addresses that with partial support. Some things are still missing and will be addressed in a future MR, notably:

  • We should support disabling features.
  • We do not handle ligoLanguageServer.deprecated.
  • We don't handle dynamic configuration changes. We need to patch linol in order to make it work.

Component

  • compiler
  • website
  • webide
  • vscode-plugin
  • debugger

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance improvement (non-breaking change that improves performance)
  • None (change with no changelog)

Changelog

Add support for decoding "maximum number of problems" and "verbosity" from the VS Code configuration.

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • Start titles under ## Changelog section with #### (if appropriate).
  • There is no image or uploaded file in changelog
  • Examples in changed behaviour have been added to the changelog (for breaking change / feature).
Edited by Heitor Toledo Lassarote de Paula

Merge request reports