Skip to content

[Package Management]: Fix bug in dependency resolution in ModRes

Melwyn Saldanharequested to merge
fix/package-resolution into dev

type:fixed

Checklist:

  • Changes follow the existing coding style (use dune @fmt to check).
  • Tests for the changes have been added (for bug fixes / feature).
  • (NA) Documentation has been updated.
  • Changelog description has been added (if appropriate).
  • (NA) Examples in changed behaviour have been added (for breaking change / feature).

Motivation and Context

The function get_dependencies in ModRes depended on Path.is_prefix which was buggy because the order of dependencies in resolutions mattered.

Currently we use Path.equal to resolve the exact dependency which makes it independent of the oder of dependencies in resolutions.

Description

This MR fixes bugs in resolving external packages (ModRes) & adds tests in order to prevent regressions

Changelog description

Changelog details: Fixes bug in resolution of external packages

Edited by Melwyn Saldanha

Merge request reports