Skip to content
Snippets Groups Projects

Fix unnecessary warning emitted from muchused.ml

Merged Melwyn Saldanha requested to merge melwyn95/fix-warning-muchused into dev

Problem

There was a missing checks for chest & chest_key in muchused.ml related to is_dup,

That was emitting a warning which chest or chest_key was used more than once.

Solution

The simple solution would be to add the 2 missing checks,

But in order to prevent such error in future the constant types are defined as a Variant,

Such errors will be easily caught by exhaustiveness check of pattern matching

  • has a changelog entry
Edited by Melwyn Saldanha

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading