Skip to content

Separated docker-compose.yml

Giovanni Marelli requested to merge deploy into master

Few comments on the proposition:

  • a dedicated docker-compose.yml
  • handle the auth inside of the application
  • don't see no Web Server Gateway Interface, risk in production
  • don't see workers set
  • change the port to 5007 to avoid conflicts
  • don't see any documentation, swagger or similar
  • tried the test I don't get the output, are you checking connections by chance?
  • A single file 500+ lines long, can that be split to help readability?
  • don't get the offset logic, can you maybe explain it?
  • you are putting a hard coded limit on buffer size but we saw messages being larger than 4MB
  • hit /v1/topics and got 500: no errors (nor console or request response)

Merge request reports