- Sep 15, 2020
-
-
Pino Toscano authored
Implement the .domainInterfaceAddresses hypervisor API, although only functional for the VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT source. Signed-off-by:
Pino Toscano <ptoscano@redhat.com> Reviewed-by:
Michal Privoznik <mprivozn@redhat.com>
-
Pino Toscano authored
Add the definition of the GuestNicInfo object, with all the required objects for it. Signed-off-by:
-
Pino Toscano authored
Implement the .connectListAllNetworks networks API in the esx network driver. Signed-off-by:
-
Allow vfio-ccw mdev devices to be created besides vfio-pci mdev devices as well. Reviewed-by:
Erik Skultety <eskultet@redhat.com> Reviewed-by:
Bjoern Walk <bwalk@linux.ibm.com> Signed-off-by:
Boris Fiuczynski <fiuczy@linux.ibm.com>
-
Make Direct Access Storage Devices (DASDs) available in the node_device driver. Reviewed-by:
-
Allow to filter for CSS devices. Reviewed-by:
-
Make channel subsystem (CSS) devices available in the node_device driver. The CCS devices reside in the computer system and provide CCW devices, e.g.: +- css_0_0_003a | +- ccw_0_0_1a2b | +- scsi_host0 | +- scsi_target0_0_0 | +- scsi_0_0_0_0 Reviewed-by: -
Refactor out CCW address parsing for later reuse. Reviewed-by:
-
- Sep 14, 2020
-
-
Jano Tomko authoredAfter we started copying the privateData pointer in qemuDomainObjRestoreJob, we should also free them once we're done with them. Register the clear function and use g_auto. Also add a check for job->cb to qemuDomainObjClearJob, to prevent freeing an uninitialized job. https://bugzilla.redhat.com/show_bug.cgi?id=1878450 Signed-off-by:
Ján Tomko <jtomko@redhat.com> Fixes: aca37c3f
-
Jano Tomko authored
The function used g_clear_pointer for all but one pointer. Signed-off-by: -
Jano Tomko authored
This function does not free the job. Signed-off-by: -
Signed-off-by:
Tim Wiederhake <twiederh@redhat.com> Reviewed-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
testConfRoundTrip would return 0 (success) if virConfWriteMem succeeded and virTestCompareToFile failed. Signed-off-by:
-
Signed-off-by:
Lin Ma <lma@suse.de> Reviewed-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Currently this patch works for the commands emulatorpin, iothreadpin and vcpupin. Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Commit c7151b0e added the completion for VSH_OT_INT options, say '--cellno' and '--pagesize', So we need to ignore VSH_OT_INT otherwise we get the incorrect completion. before: # virsh freepages --pagesize <TAB><TAB> --all --cellno 1GiB 2MiB 4KiB after: # virsh freepages --pagesize <TAB><TAB> 1GiB 2MiB 4KiB Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Signed-off-by:
-
Commit 3b225256 removed unused VIR_CONNECT_LIST_DOMAINS_* flags, But some of them will be used in upcoming patches, So add some of them back. Signed-off-by:
-
Jano Tomko authored
Signed-off-by:
-
Pino Toscano authored
A lot of virReportError() calls use VIR_ERR_INTERNAL_ERROR to represent the number of the error, even in cases where there is one fitting more. Hence, replace some of them with better virErrorNumber values. Signed-off-by:
Martin Kletzander <mkletzan@redhat.com>
-
Pino Toscano authored
When a list is freed, we iterate through all the items, invoking the free function for each; the actual free function called for each element is the function of the actual type of each element, and thus the @_next pointer in the element struct has the same type as the element itself. Currently, the free function gets the parent of the current element type, and invoke its free function to continue freeing the list. However, in case the hierarchy of the classes has more than 1 level (i.e. Class <- SubClass <- SubSubClass), the invoked free function is only the parent class' one, and not the actual base class of the hierarchy. To fix that, change the generator to get the base class of a class, and invoking that instead. Also, avoid to set the @_next back, as it is not needed. Fixes commits 5cff36e3 and f76c6dde. Signed-off-by:
-
Pino Toscano authored
Implement the .domainGetHostname hypervisor driver API to get the hostname of a running guest (needs VMware Tools). Signed-off-by:
Neal Gompa <ngompa13@gmail.com>
-
- Sep 13, 2020
-
-
The original motivation for adding virNetDevIPCheckIPv6Forwarding (commit 00d28a78) was that networking routes would disappear when ipv6 forwarding was enabled for an interface. This is a fairly undocumented side-effect of the "accept_ra" sysctl for an interface. 1 means the interface will accept_ra's if not forwarding, 2 means always accept_RAs; but it is not explained that enabling forwarding when accept_ra==1 will also clear any kernel RA assigned routes, very likely breaking your networking. The check to warn about this currently uses netlink to go through all the routes and then look at the accept_ra status of the interfaces. However, it has been noticed that this problem does not affect systems where IPv6 RA configuration is handled in userspace, e.g. via tools such as NetworkManager. In this case, the error message from libvirt is spurious, and modifying the forwarding state will not affect the RA state or disable your networking. If you refer to the function rt6_purge_dflt_routers() in the kernel, we can see that the routes being purged are only those with the kernel's RTF_ADDRCONF flag set; that is, routes added by the kernel's RA handling. Why does it do this? I think this is a Linux implementation decision; it has always been like that and there are some comments suggesting that it is because a router should be statically configured, rather than accepting external configurations. The solution implemented here is to convert the existing check into a walk of /proc/net/ipv6_route (because RTF_ADDRCONF is apparently not exposed in netlink) and look for routes with this flag set. We then check the accept_ra status for the interface, and if enabling forwarding would break things raise an error. This should hopefully avoid "interactive" users, who are likely to be using NetworkManager and the like, having false warnings when enabling IPv6, but retain the error check for users relying on kernel-based IPv6 interface auto-configuration. Signed-off-by:
Ian Wienand <iwienand@redhat.com> Reviewed-by:
Laine Stump <laine@redhat.com> Reviewed-by:
Cedric Bosdonnat <CBosdonnat@suse.com>
-
- Sep 12, 2020
-
-
Signed-off-by:
-
