Skip to content
Snippets Groups Projects
Commit 92430a69 authored by Peter Krempa's avatar Peter Krempa Committed by Eric Blake
Browse files

CVE-2014-3633: qemu: blkiotune: Use correct definition when looking up disk

Live definition was used to look up the disk index while persistent one
was indexed leading to a crash in qemuDomainGetBlockIoTune. Use the
correct def and report a nice error.

Unfortunately it's accessible via read-only connection, though it can
only crash libvirtd in the cases where the guest is hot-plugging disks
without reflecting those changes to the persistent definition.  So
avoiding hotplug, or doing hotplug where persistent is always modified
alongside live definition, will avoid the out-of-bounds access.

Introduced in: eca96694 (v0.9.8)
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140724


Reported-by: default avatarLuyao Huang <lhuang@redhat.com>
Signed-off-by: default avatarPeter Krempa <pkrempa@redhat.com>

(cherry picked from commit 3e745e8f)
parent 14750f1d
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment