Skip to content
Snippets Groups Projects
Commit 186412fe authored by Jano Tomko's avatar Jano Tomko
Browse files

virDomainDeviceAliasIsUserAlias: tolerate NULL


Do not crash in virDomainDeviceInfoParseXML if someone provides
an 'alias' element without a 'name' attribute.

Signed-off-by: default avatarJán Tomko <jtomko@redhat.com>
parent 5123e6ed
No related branches found
No related tags found
No related merge requests found
......@@ -5573,7 +5573,7 @@ virDomainDeviceDefValidateAliasesIterator(virDomainDefPtr def,
struct virDomainDefValidateAliasesData *data = opaque;
const char *alias = info->alias;
 
if (!alias || !virDomainDeviceAliasIsUserAlias(alias))
if (!virDomainDeviceAliasIsUserAlias(alias))
return 0;
 
/* Some crazy backcompat for consoles. */
......@@ -6702,7 +6702,7 @@ virDomainDeviceAddressParseXML(xmlNodePtr address,
bool
virDomainDeviceAliasIsUserAlias(const char *aliasStr)
{
return STRPREFIX(aliasStr, USER_ALIAS_PREFIX);
return aliasStr && STRPREFIX(aliasStr, USER_ALIAS_PREFIX);
}
 
 
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment