tiffcrop: heap-buffer-overflow in /tiff-4.5.0/tools/tiffcrop.c:3863:24 in extractContigSamplesShifted16bits

Summary

There is a buffer overflow in /tiff-4.5.0/tools/tiffcrop.c:3863:24 in extractContigSamplesShifted16bits. Remote attackers could leverage this vulnerability to cause a denial-of-service via a crafted tiff file.

Version

./tiffcrop -v
Library Release: LIBTIFF, Version 4.5.0
Copyright (c) 1988-1996 Sam Leffler
Copyright (c) 1991-1996 Silicon Graphics, Inc.
Tiffcp code: Copyright (c) 1988-1997 Sam Leffler
           : Copyright (c) 1991-1997 Silicon Graphics, Inc
Tiffcrop additions: Copyright (c) 2007-2010 Richard Nolde

Platform

uname -a 
Linux user-GE40-2PC-Dragon-Eyes 5.19.0-40-generic #41~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Fri Mar 31 16:00:14 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

ASAN_heap-buffer-overflow

==909846==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x631000011003 at pc 0x562ea169e80d bp 0x7ffee6008830 sp 0x7ffee6008828
WRITE of size 1 at 0x631000011003 thread T0
    #0 0x562ea169e80c in extractContigSamplesShifted16bits /home/user/fuzzing_tiff/tiff-4.5.0/tools/tiffcrop.c:3863:24
    #1 0x562ea1669f41 in extractCompositeRegions /home/user/fuzzing_tiff/tiff-4.5.0/tools/tiffcrop.c:7464:38
    #2 0x562ea1669f41 in processCropSelections /home/user/fuzzing_tiff/tiff-4.5.0/tools/tiffcrop.c:8504:13
    #3 0x562ea1669f41 in main /home/user/fuzzing_tiff/tiff-4.5.0/tools/tiffcrop.c:2807:21
    #4 0x7f0c41e29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #5 0x7f0c41e29e3f in __libc_start_main csu/../csu/libc-start.c:392:3
    #6 0x562ea1597284 in _start (/home/user/fuzzing_tiff/install/bin/tiffcrop+0xd7284) (BuildId: b74ccf7dfc4e9a79)

0x631000011003 is located 0 bytes to the right of 67587-byte region [0x631000000800,0x631000011003)
allocated by thread T0 here:
    #0 0x562ea161a0ce in malloc (/home/user/fuzzing_tiff/install/bin/tiffcrop+0x15a0ce) (BuildId: b74ccf7dfc4e9a79)
    #1 0x562ea1669634 in _TIFFmalloc /home/user/fuzzing_tiff/tiff-4.5.0/libtiff/tif_unix.c:326:13
    #2 0x562ea1669634 in processCropSelections /home/user/fuzzing_tiff/tiff-4.5.0/tools/tiffcrop.c
    #3 0x562ea1669634 in main /home/user/fuzzing_tiff/tiff-4.5.0/tools/tiffcrop.c:2807:21
    #4 0x7f0c41e29d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/user/fuzzing_tiff/tiff-4.5.0/tools/tiffcrop.c:3863:24 in extractContigSamplesShifted16bits
Shadow bytes around the buggy address:
  0x0c627fffa1b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c627fffa1c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c627fffa1d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c627fffa1e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c627fffa1f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c627fffa200:[03]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c627fffa210: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c627fffa220: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c627fffa230: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c627fffa240: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c627fffa250: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==909846==ABORTING

Steps to reproduce

./tiffcrop -E right  -z 1,1,2048,2048:1,2049,2048,4097 -i -s $poc_file /tmp/foo

POC File

poc_of_3863

Credit

Gandalf4a@QAXsrc