tiffcrop subroutines require a larger buffer (fixes #271, #381, #386, #388, #389, #435)

Closes #465, #464, #435, #389, #388, #386, #381 et #271

See merge request !382

Revised handling of TIFFTAG_INKNAMES and related TIFFTAG_NUMBEROFINKS value (fixes #149, #150, #152, #168, #250, #269, #398 and #456)

Closes #474, #463, #387, #456, #398, #269, #250, #168, #152, #150 et #149

See merge request !385

tiffcrop: disable incompatibility of -Z, -X, -Y, -z options with any PAGE_MODE_x option (fixes #411, #413 and #426)

Closes #426, #413 et #411

See merge request !383

TIFFAdvanceDirectory(): fix unsigned-integer-overflow in mapped case

See merge request !398

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52309

tiffinfo: Updated to parse through SubIFDs and show their tags.

See merge request !396

Moved linking of CMath::CMath into CMath_LIBRARY check

See merge request !397

rational_precision2double.c: Fix issue from Coverity Scan.

See merge request !395

Improved IFD-Loop Handling (fixes #455)

Closes #455

See merge request !386

Su Laus authored 2 years ago and Even Rouault committed 2 years ago

IFD infinite looping was not fixed by MR 20 (see #455).
An improved IFD loop handling is proposed.

Basic approach:

- The order in the entire chain must be checked, and not only whether an offset has already been read once.
- To do this, pairs of directory number and offset are stored and checked.
- The offset of a directory number can change.
- TIFFAdvanceDirectory() must also perform an IFD loop check.
- TIFFCheckDirOffset() is replaced by _TIFFCheckDirNumberAndOffset().

Rules for the check:

- If an offset is already in the list, it must have the same IFD number. Otherwise it is an IDF loop.
- If the offset is not in the list and the IFD number is greater than there are list entries, a new list entry is added.
- Otherwise, the offset of the IFD number is updated.

Reference is also made to old bugzilla bug 2772 and MR 20, which did not solve the general issue.
This MR closes #455

Fix CMake build to be compatible with FetchContent

See merge request !394

Recent versions of CMake have improved support for including
dependencies, using the FetchContent module, which allows a dependency
to be imported as a subproject and then later found automatically by
calls to `find_package`.

This change makes libtiff's CMake better behaved when used as a
sub-project:

- CMake has a single global namespace for all target names in all
  sub-projects.  This commit renames the following CMake targets:

  - port -> tiff_port
  - mkg3states -> tiff_mkg3states
  - faxtable -> tiff_faxtable
  - release -> tiff_release

- When building TIFF as a sub-project, it is not normally useful to
  create install rules for its targets.  This commit adds a
  `tiff-install` option that controls whether the install rules are
  added and defaults to OFF when libtiff is included as a sub-project.

- Previously, libtiff set `BUILD_SHARED_LIBS` to ON by default.  With
  this commit, that default is only set if libtiff is the top-level
  project.

- When using `find_package(TIFF)`, the targets `TIFF::TIFF` and
  `TIFF::CXX` are defined.  This commit makes libtiff itself define
  those targets as aliases, to allow other cmake projects to use
  either `find_package` or `FetchContent` interchangeably.

- Adds ZSTD_HAVE_DECOMPRESS_STREAM variable which may be set to bypass
  `check_symbol_exists` call.  Fixes
  #472.

Update getimage to support reading large raster images

See merge request !389

Fix #458: MinGW Windows 64: warning because 'long' is a 32 bits type in...

Closes #458

See merge request !391

tif_lzw.c: fix typo in code comment

See merge request !387

In order to solve the buffer overflow issues related to TIFFTAG_INKNAMES and related TIFFTAG_NUMBEROFINKS value, a revised handling of those tags within LibTiff is proposed:

Behaviour for writing:
    `NumberOfInks`  MUST fit to the number of inks in the `InkNames` string.
    `NumberOfInks` is automatically set when `InkNames` is set.
    If `NumberOfInks` is different to the number of inks within `InkNames` string, that will be corrected and a warning is issued.
    If `NumberOfInks` is not equal to samplesperpixel only a warning will be issued.

Behaviour for reading:
    When reading `InkNames` from a TIFF file, the `NumberOfInks` will be set automatically to the number of inks in `InkNames` string.
    If `NumberOfInks` is different to the number of inks within `InkNames` string, that will be corrected and a warning is issued.
    If  `NumberOfInks` is not equal to samplesperpixel only a warning will be issued.

This allows the safe use of the NumberOfInks value to read out the InkNames without buffer overflow

This MR will close the following issues:  #149, #150, #152, #168 (to be checked), #250, #269, #398 and #456.

It also fixes the old bug at http://bugzilla.maptools.org/show_bug.cgi?id=2599, for which the limitation of `NumberOfInks = SPP` was introduced, which is in my opinion not necessary and does not solve the general issue.

tiffcrop: disable incompatibility of -Z, -X, -Y, -z options with any PAGE_MODE_x option (fixes #411 and #413)

tiffcrop does not support –Z, -z, -X and –Y options together with any other PAGE_MODE_x options like  -H, -V, -P, -J, -K or –S.

Code analysis:

With the options –Z, -z, the crop.selections are set to a value > 0. Within main(), this triggers the call of processCropSelections(), which copies the sections from the read_buff into seg_buffs[].
In the following code in main(), the only supported step, where that seg_buffs are further handled are within an if-clause with  if (page.mode == PAGE_MODE_NONE) .

Execution of the else-clause often leads to buffer-overflows.

Therefore, the above option combination is not supported and will be disabled to prevent those buffer-overflows.

The MR solves issues #411 and #413.

tiffcrop:  -S option mutually exclusive (fixes #349, #414, #422, #423, #424)

Closes #424, #423, #422, #414 et #349

See merge request !378

Remove dead code from tif_dirread.c, tif_dirwrite.c and tif_getimage.c

See merge request !380

Silence Coverity Scan false positive warnings about out-of-bounds access

See merge request !379

tif_zip.c: silence Coverity Scan false positive warnings about out-of-bounds access (CID 1491190, 1491197, 1491201)

tif_dirread.c: silence Coverity Scan false positive warnings about out-of-bounds access (CID 1491182, 1491186)

Presetting of default tag values extended (e.g. PlanarConfig). (fixes #449)

Closes #449

See merge request !377

According to Richard Nolde #401 (comment 877637400) the tiffcrop option „-S“ is also mutually exclusive to the other crop options (-X|-Y), -Z and -z.

This is now checked and ends tiffcrop if those arguments are not mutually exclusive.

This MR will fix the following tiffcrop issues: #349, #414, #422, #423, #424

Fix warning about shadowing

See merge request !376

Deal with RichTIFFIPTC tag written with LONG type (fixes #225)

Closes #225

See merge request !374

Correcting defects reported by Coverity Scan for MR !369

See merge request !375