misc: replace strcpy with strlcpy in ssh_get_user_home_dir_internal

Om Upadhyayrequested to merge
om_upadhyay/libssh-mirror:fix-strlcpy-misc-c into master

Replace the last strcpy() in src/misc.c (Windows-only ssh_get_user_home_dir_internal()) with strlcpy().

szPath is allocated as strlen(tmp) + 1 bytes right before the copy, so that size is passed as the capacity. No functional change.

Remaining strncpy()/strncat() sites in tests and examples will be handled separately.

Part of #361

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTING.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Merge request reports