Skip to content

Draft: Add ability to retrieve last PKI related error message

John Thacker requested to merge johnthacker/libssh-mirror:232-ssh_pki_error into master

Add a API function ssh_pki_get_error to retrieve the last PKI related error message. Many PKI related error messages are recoverable errors that ought to be displayed to a user, e.g. the wrong passphrase for a key.

Other solutions like setting the overall log to SSH_LOG_TRACE and displaying all logs to a user (or making a user read a log file, or parsing the log messages in a callback to determine what to display, etc.) are less than ideal.

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTING.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code

Closes #232

Edited by John Thacker

Merge request reports