Skip to content

tests: Give the server more time handle rekey

Jakub Jelenrequested to merge
jjelen/libssh-mirror:rekey-timeout into master

The latest release had some issues in getting into Fedora as the 0.10.5 release failed with the following tests on i686 architecture with specific OpenSSH changes that used the new OpenSSL API:

[  FAILED  ] tests: 2 test(s), listed below:
[  FAILED  ] torture_rekey_different_kex
[  FAILED  ] torture_rekey_server_different_kex

Initially, we thought that the new OpenSSL API is to blame, but it turned out that the rekey just needed more time to process in this configuration. First test with adding "stupid" sleep worked so this is a workaround that should fix the test also on slower machines/architectures/configurations. For more information, see the following Fedora bug:

https://bugzilla.redhat.com/show_bug.cgi?id=2203241

Checklist

  • Commits have Signed-off-by: with name/author being identical to the commit author
  • Code modified for feature
  • Test suite updated with functionality tests
  • Test suite updated with negative tests
  • [-] Documentation updated

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTING.md
  • This feature/change has adequate documentation added
  • No obvious mistakes in the code
Edited by Jakub Jelen

Merge request reports