WIP: Deprecate duplicate/ unused functions
Add a description of the new feature/bug fix. Reference any relevant bugs.
Checklist
-
Commits have Signed-off-by:
with name/author being identical to the commit author -
Code modified for feature -
Test suite updated with functionality tests -
Test suite updated with negative tests -
Documentation updated
Reviewer's checklist:
-
Any issues marked for closing are addressed -
There is a test suite reasonably covering new functionality or modifications -
Function naming, parameters, return values, types, etc., are consistent and according to CONTRIBUTING.md -
This feature/change has adequate documentation added -
No obvious mistakes in the code
I have tried to go through most functions that don't start with 'ssh' and made sure they are deprecated. I have removed references to these deprecated functions. Removed extra white spaces as and when found.
I went through most of ssh_message_*() functions. I deprecated those that need be used anymore, thanks to the callback based server implementation we have now.
I will keep this as WIP till I go over all the functions in src/ABI/libssh-4.8.1.symbols again.
I still need to wrap these below functions around pki.c functions.
void privatekey_free(ssh_private_key prv);
ssh_private_key privatekey_from_file(ssh_session session, const char *filename,
int type, const char *passphrase);
int ssh_publickey_to_file(ssh_session session, const char *file,
ssh_string pubkey, int type);
ssh_string publickey_to_string(ssh_public_key key);