Skip to content

Fix for crash bug in SPQRSupport: Initialize pointers to nullptr to avoid free() calls of invalid pointers.

Martin Heistermannrequested to merge
mheistermann/eigen:fix-spqr-crash into master

Reference issue

No issue filed, should I add one?

What does this implement/fix?

If SuiteSparseQR fails, m_isInitialized is set to false, but some pointers stay uninitialized. Then in the destructor, they are still free'd, causing a crash. Initializing the pointers to nullptr fixes the issue, as both std::free and cholmod_l_free_* are no-op for null pointers.

Additional information

N/A

Merge request reports