Skip to content

fix implicit conversion warning in vectorwise_reverse_inplace

Arthurrequested to merge
arthurfeeney/eigen:reverse_index_type_fix into master

Reference issue

This fixes warning 2 in Issue #2400 (closed); the implicit conversion from Eigen::Index to int in vectorwise_reverse_inplace_impl

I also noticed this warning when building the BDCSVD tests.

What does this implement/fix?

There's a new warning when building the tests about an implicit conversion from Index to int in Reverse, when it uses fix<N>(n).

This update just explicitly casts half from an Index to an int to remove the conversion warning. Since as far as I can see, fix<N>(n) only works with int, this casting should be equivalent to how it was before the recent changes.
Before the recent cleanup, the pre-c++14 version of fix took the runtime value generically, and then manually cast it down to an int. So I think there was generally no implicit conversion.

Merge request reports