Skip to content

Fix IterativeSolverBase referring to itself as ConjugateGradient

Essex Edwardsrequested to merge
essex.edwards/eigen:feature/fix_iterative_solver_assertion_messages into master

What does this implement/fix?

Two assertion messages in IterativeSolverBase refer to it as ConjugateGradient. This is incorrect, as the derived class could be several different solvers, not just CG.

This MR changes those assertion messages to say IterativeSolverBase instead. This is consistent with another identical assertion further down in the file that is already saying "IterativeSolverBase is not initialized."

Based on this git history, it looks like IterativeSolverBase was made by extracting code out of ConjugateGradient and that these messages were copy-pasted at that time without being modified. A simple copy-paste error.

Merge request reports