Skip to content

cmake: remove deprecated package config variables

Sergiu Deitsch requested to merge sergiud/eigen:cmake-deprecated-config-variables into master

What does this implement/fix?

This MR removes deprecated EIGEN3_* variables and related CMake files that were provided for compatibility purposes with previously provided find module. Their use, however, was discouraged and therefore declared deprecated almost five years ago with the introduction of the relocatable package config in 5c516e4e.

Additional information

Removing deprecated CMake variables exposed by the package config can help avoid subtle errors that can be caused by intermixing FindEigen3.cmake and the Eigen3Config.cmake package config. The documentation does not mention the deprecated CMake variables anyway. The changes also effectively eliminate the need for workarounds required to solve #1386 (closed).

We should also likely remove FindEigen3.cmake (and maybe FindEigen2.cmake?) which mostly duplicate Eigen3Config.cmake while preventing best CMake practices by caching all the paths and increasing the maintenance burden at no additional value.

Edited by Sergiu Deitsch

Merge request reports