Inline IndexedViewMethods.inc into DenseBase.h
Summary
Inline the contents of Eigen/src/plugins/IndexedViewMethods.inc directly into DenseBase.h and remove the .inc file.
- Makes the indexed view
operator()overloads discoverable directly inDenseBase.hrather than hidden behind a plugin include - The file was only included from
DenseBase.h(confirmed by grep) - All code, SFINAE style (return-type SFINAE),
EIGEN_PARSED_BY_DOXYGENguards, and Doxygen documentation preserved exactly as-is - Net change: -193 lines (deleted .inc) / +185 lines (inlined into DenseBase.h) = -8 lines total
Test plan
Local Docker (GCC 15, CMake 3.31, Debian trixie, C++17):
| Test suite | Tests | Result |
|---|---|---|
indexed_view |
1 variant |
|
stl_iterators |
1 variant |
|
block |
12 variants + 10 fail tests |
|
reshape |
1 variant |
|
mapped_matrix |
4 variants |
|
redux |
4 variants |
|
vectorwiseop |
7 variants |
|
array_cwise |
31 variants |
|
product_small |
43 variants |
|
product_large |
9 variants |
|
basicstuff |
8 variants |
|
| Total | 139 tests | 138/139 pass |
The single failure (basicstuff_8) is a known pre-existing flaky test (random-seed-dependent casting comparison) unrelated to this change.
Closes #2766
Edited by Pavel Guzenfeld