Skip to content

Make Eigen::Map<const Vector>::operator[] return correct type

What does this implement/fix?

This PR aims to make Eigen::Map<const Vector>::operator[]

  • Before: return Scalar
  • After: return const Scalar&

What is changed?

1 code line in src/core/DenseCoeffsBase.h, with 4 comment lines on it proving why it could be modified like this,

Would it bring side-effects?

No. This PR only points out that, objects with no LvalueBit but DirectAccessBit can always make there coeffs const-referencable. Examples like Map<const Vector> and TensorMap<const Tensor> will benefit from it.

Edited by anonymouspc

Merge request reports

Loading