Add nvc++ support

Morris Hafnerrequested to merge
mmha_nv/eigen:nvhpc-support-master into master

What does this implement/fix?

This patch adds a configuration macro for the nvc++ compiler and uses it to fix a compiler error when compiling code using ARM NEON intrinsics.

It also fixes a minor problem with the testing build script where CMake did not separate compiler flags and passed them as a whole to the compiler driver (e. g. nvc++ "-O2 -g" "file.cpp" instead of nvc++ "-O2" "-g" "file.cpp"). While gcc and clang separate these flags in the driver, nvc++ does not.

Additional information

  • I noticed that there's still configuration macros for the PGI compiler in place. The PGI compilers were rebranded to NVHPC in 2020 so depending on how long you plan to support legacy compilers it might make sense to remove them.
  • Can we also add this patch to the 3.4 branch? If so, do I create another MR for that?

Merge request reports