Fix triangular matrix-vector multiply uninitialized warning.

Antonio Sánchezrequested to merge
cantonios/eigen:qr into master

The warning seems to be caused by a mix of

  • const_cast abuse, to convert actualRhs.data() from const to non-const, for no other reason than we might copy into actualRhsPtr if we end up allocating a temporary buffer.
  • potential use of alloca to allocate a temporary buffer
  • the confusing mix and match of a bunch of conditionals.

Explicitly spelling everything out and skipping the const_cast abuse, we get the same behavior, but without the warning.

Fixes #2787 (closed).

Merge request reports