Fix annoying warnings
Reference issue
What does this implement/fix?
This resolves all of the compiler warnings in clang default/avx2. There are many outstanding warnings in gcc. Summary of changes:
-
equal_strictno longer complains about comparing unsigned/signed integers. To address this, I check if the signed argument is negative, return false if so, otherwise cast it to its unsigned counterpart and do the comparison. - dot no longer complains about an unused typedef
- pcarg no longer complains about an unused typedef
- plainobjectbase::_init2 no longer complains about an unused typedef
- ref.h enum comparisons
- SVD uninitialized variables
- arraycwise underflow issues with arm
- deleted a bunch of stupid tests and split up the remaining tests in arraycwise to help with CI failures due to lack of resources
- random_cast_without_overflow -- dont negate unsigned arguments
- std_vector test doesnt complain about un-initialized memory (for a test that's not run!)
- tensorblock: enum comparisons
- FFT: change enum to constexpr variables to avoid shadowing existing
Defaultenum in Core - disable deprecation warning in euler angles
- NNLS no longer complains about unused typedef
- tensor casts: use cast_impl instead of static_cast to correctly handle real->complex casts
- tensor reduction: judiciously cast to double
- make convert_index fancier by handling signed/unsigned integer range check
Additional information
Edited by Charles Schlosser