Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • lfortran lfortran
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 432
    • Issues 432
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 72
    • Merge requests 72
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lfortranlfortran
  • lfortranlfortran
  • Merge requests
  • !1640

Fix order deps ordered

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tobias Loew requested to merge tobias-loew/lfortran:fix_order_deps_ordered into master Jan 09, 2022
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 3

This fixes the UB, but uses a std::map instead of a std::unordered_map : using unordered_map resulted in failing tests, as some of the dependency-resolving tests may have multiple solutions. E.g.

  • mod_1 depends on mod_2
  • mod_1 depends on mod_3

can be resolved by [mod_2, mod_3, mod_1] but also by [mod_3, mod_2, mod_1]

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_order_deps_ordered