Skip to content
Snippets Groups Projects

Split ast_to_asr

Merged Rohit Goswami requested to merge HaoZeke/lfortran:refactorAST2ASR into master
All threads resolved!

Closes #467 (closed).

Edited by Rohit Goswami

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Rohit Goswami

      I thought we agreed to just split the file, but not do any other refactoring. This MR seems to be doing quite a lot of refactoring, which I suggest we do not do at this time. Rather, let's implement an MVP, or even most of Fortran features, then try to brainstorm how to best design the AST->ASR pass and possibly refactor then.

  • Rohit Goswami resolved all threads

    resolved all threads

  • Rohit Goswami requested review from @certik

    requested review from @certik

  • Rohit Goswami changed title from Refactor ast_to_asr to Split ast_to_asr

    changed title from Refactor ast_to_asr to Split ast_to_asr

  • Rohit Goswami added 6 commits

    added 6 commits

    Compare with previous version

  • Rohit Goswami added 9 commits

    added 9 commits

    Compare with previous version

  • Ondřej Čertík approved this merge request

    approved this merge request

  • requested review from @czgdp18071

  • I think that looks good to me. @czgdp18071 can you also please review this?

  • The tests are working without change. The code is segregated and looks good. Thanks @HaoZeke for putting in the effort for doing this.

  • Gagandeep Singh approved this merge request

    approved this merge request

  • @HaoZeke go ahead and merge.

  • Rohit Goswami mentioned in commit 610864a8

    mentioned in commit 610864a8

  • merged

  • Please register or sign in to reply
    Loading