Split ast_to_asr
Closes #467 (closed).
Merge request reports
Activity
added GSoC label
assigned to @HaoZeke
added 6 commits
-
8ad07905...297475ba - 4 commits from branch
lfortran:master
- a4e5d127 - semantics: Split naively
- 1edda17b - ast2asr: Cleaner implementation
-
8ad07905...297475ba - 4 commits from branch
- Resolved by Rohit Goswami
- Resolved by Rohit Goswami
- Resolved by Rohit Goswami
I thought we agreed to just split the file, but not do any other refactoring. This MR seems to be doing quite a lot of refactoring, which I suggest we do not do at this time. Rather, let's implement an MVP, or even most of Fortran features, then try to brainstorm how to best design the AST->ASR pass and possibly refactor then.
requested review from @certik
added 6 commits
-
a4e5d127...cda21b64 - 5 commits from branch
lfortran:master
- 84bc97fd - semantics: Split naively
-
a4e5d127...cda21b64 - 5 commits from branch
added 9 commits
-
84bc97fd...932aa0fa - 8 commits from branch
lfortran:master
- eb341814 - semantics: Split naively
-
84bc97fd...932aa0fa - 8 commits from branch
requested review from @czgdp18071
I think that looks good to me. @czgdp18071 can you also please review this?
The tests are working without change. The code is segregated and looks good. Thanks @HaoZeke for putting in the effort for doing this.
@HaoZeke go ahead and merge.
mentioned in commit 610864a8