Skip to content

Draft: qemu.jinja2: Fix indentation, vga and serial options and kvm enabled everywhere

Igor Ponomarev requested to merge qemu-jinja-template-fix-architecture-if-else-blocks into master

This is potentially breaking change which needs more discussion.

Closes #638

Fix lists indentations. Particularly the available_architectures and options.

Fix vga and serial options only being available when emulating ARM architecture. Also fix those options not prepending -vga and -serial to passed values.

Only enable KVM when the host supports it. For x86_64 which is assumed in qemu.jinja2 only architectures that support it are i386, amd64 and x86_64. For Aarch64 in qemu-aarch64.jinja2 those are aarch64, arm64 and arm.

Some options sections renders:

qemu-aarch with arch="aarch64"

          options:
            - -cpu cortex-a57
            - -machine virt
            - -cpu host
            - -enable-kvm
            - -nographic
            - -net nic,model=virtio,macaddr=52:54:00:12:34:58 -net user
            - -m 512
            - -monitor none

qemu-aarch with arch="x86_64"

          options:
            - -nographic
            - -net nic,model=virtio,macaddr=52:54:00:12:34:58 -net user
            - -m 512
            - -monitor none

qemu with arch="aarch64"

          options:
            - -cpu cortex-a57
            - -machine virt
            - -nographic
            - -net nic,model=virtio,macaddr=52:54:00:12:34:58 -net user
            - -m 512
            - -monitor none

qemu with arch="x86_64"

          options:
            - -cpu host
            - -enable-kvm
            - -nographic
            - -net nic,model=virtio,macaddr=52:54:00:12:34:58 -net user
            - -m 512
            - -monitor none

Merge request reports