AddressBook: publishers file loaded twice (consecutively)
Created by: anonimal
By submitting this issue, I confirm the following:
- I have read and understood the contributor guide.
- I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
- I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.
Place an X inside the bracket to confirm
-
I confirm.
I've never seen this happen before now. Brought to #kovri-dev
by @kenshi84.
Kenshis-MacBook-Pro:~ kenshi$ kovri
Crypto: checking for AES-NI...
Crypto: AES-NI is available!
The Kovri I2P Router Project
Version 0.1.0-pre-alpha
Instance: configuring
Configuration: using log levels: warn error info
2017:01:04|10:48:27.164287|NFO Instance: 3 client tunnels created
2017:01:04|10:48:27.164937|NFO Instance: 0 server tunnels created
2017:01:04|10:48:27.166731|NFO Instance: listening on port 22537
2017:01:04|10:48:27.178322|NFO Reseed: fetching from https://i2p.manas.ca:8443/i2pseeds.su3
2017:01:04|10:48:37.442354|WRN RouterInfo: unexpected SSU address tisa.ddns.net
2017:01:04|10:48:37.444745|WRN RouterInfo: unexpected SSU address enops.org
2017:01:04|10:48:37.468649|NFO Reseed: implementation successful
2017:01:04|10:48:37.528159|NFO I2PService: Irc2P accepted
2017:01:04|10:48:37.528345|NFO AddressBook: loading publisher file publishers.txt
2017:01:04|10:48:37.528524|NFO AddressBook: loading publisher file publishers.txt
2017:01:04|10:48:37.529862|NFO AddressBook: 1 publishers loaded
2017:01:04|10:48:37.530023|NFO AddressBook: 2 publishers loaded
Segmentation fault: 11
If this can be reproduced, debug output would help. Also note the following:
2017-01-04 &anonimal Oh interesting, looking at your log again kenshi84, I'm wondering if it's a race condition.
2017-01-04 * anonimal thinking out loud
2017-01-04 &anonimal It was hacked (not of my doing) to begin with in terms of resolving hosts *before* address book service is started.
2017-01-04 &anonimal There's a previous TODO to move that area but it's not easily done (that's why I left it for now). I'll add a note in my TODO.
See // TODO(unassigned): HACK
GetDestIdentHash()
CheckAddressIdentHashFound()
in client/tunnel.cc
.
Referencing #305