Skip to content

Issue #54: Make BOOLEAN check more robust

Tomas Cohen Arazi requested to merge thekesolutions/qa-test-tools:issue_54 into master

This patch makes the check for BOOLEAN columns more robust.

To test:

  1. Have a commit that adds the word 'boolean' in a COMMENT entry in kohastructure.sql
  2. Run: $ kshell k$ /kohadevbox/qa-test-tools/koha-qa.pl -c 1 -v 2 => FAIL: It prints an error about BOOLEAN type, which is incorrect
  3. Have a commit that adds 'BOOLEAN' as part of an ENUM column in kohastructure.sql as well
  4. Repeat 2 => FAIL: It prints an error about BOOLEAN type, which is incorrect
  5. Apply this patch and repeat 1 through 4 => SUCCESS: No more false positives!
  6. Make a commit introducing a legit BOOLEAN column somewhere
  7. Repeat 2 => SUCCESS: It is detected as BOOLEAN and reported incorrect!
  8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi tomascohen@theke.io

Merge request reports