Skip to content

Issue #20 - Check BOOLEAN vs TINYINT(1) - SQL12

joubu requested to merge joubu/qa-test-tools:issue_20 into master

This patch will ensure our SQL12 coding guideline. https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans

Test plan: 0/ Go to your Koha repo 1/ Modify kohastructure.sql and add a new column with the type BOOLEAN 2/ Commit and execute the QA script => New check boolean_vs_tinyint will fail 3/ Replace the type with TINYINT(1) 4/ Commit and execute the QA script => New check tinyint_has_boolean_flag will fail 5/ Edit the relevant schema file to tell DBIx::Class that this new column is a boolean 6/ Commit and execute the QA script => Success!

Edited by joubu

Merge request reports