Skip to content

Enable Plack hot-reload via ENV

Thomas Klausner requested to merge perldomm/koha-testing-docker:i422_enable_plack_hot_reload_via_env into master

This patch adds a new ENV var KOHA_PLACK_HOT_RELOAD. If it is set, run.sh will stop the koha-plack that's started via koha-common and instead call plackup with a bunch of options that turn on hot reload, watching for changes in /kohadevbox/koha (i.e. the whole koha source)

As KTD is only using the pre-built images, I also mounted my localy changed run.sh into the container via the following snippet (which I did not commit, because it makes no sense as soon this commit is merged)

diff --git a/docker-compose-light.yml b/docker-compose-light.yml
index 02354d9..c457882 100644
--- a/docker-compose-light.yml
+++ b/docker-compose-light.yml
@@ -19,6 +19,7 @@ services:
             - ALL
         volumes:
             - ${SYNC_REPO}:/kohadevbox/koha
+            - ./files/run.sh:/kohadevbox/run.sh
         tmpfs:
             - /cover_db
             - /tmp

The params to plackup were extracted from koha-plack based on the values set inside KTD. I don't think it makes sense / is neccesary to dynamically calculate most of those values, as KTD is a very controlled environment.

Merge request reports