Bug 36665 and Bug 26176 - StaffLoginLibraryBasedOnIP and StaffLoginRestrictLibraryByIP

I hope I explained everything correctly. I found this very hard to understand and the bug comments were so convoluted they didn't really help...

added 42 commits

• 4a0f25b8...d9f494bb - 41 commits from branch koha-community:main
• 249c9af0 - Bug 36665 and Bug 26176 - StaffLoginLibraryBasedOnIP and StaffLoginRestrictLibraryByIP

Compare with previous version

rebased

added 12 commits

• 249c9af0...b348602f - 11 commits from branch koha-community:main
• 5aba8214 - Bug 36665 and Bug 26176 - StaffLoginLibraryBasedOnIP and StaffLoginRestrictLibraryByIP

Compare with previous version

rebased

added 4 commits

• 5aba8214...7ea3cdc7 - 3 commits from branch koha-community:main
• 12394191 - Bug 36665 and Bug 26176 - StaffLoginLibraryBasedOnIP and StaffLoginRestrictLibraryByIP

Compare with previous version

rebased again

Well, they don't make it easy, do they What you wrote makes sense to me though!

The points I noticed were regarding versions, because those two bugs were backported. The Needs documenting status is used after there are no more backports exactly for us to know which versions the enhancement made it into.

• administrationpreferences.rst line 552: bug 26176 has been backported to 23.11... So this section should say "As of Koha version 23.11.06".
• similar for line 741: bug 36665 was backported to 23.05.12 (!) so that's the version we will have to mention.
• and line 786: 23.11.06
• whatsnew.rst: now just to be contrary, I think it's ok to leave them in the 24.05 section, even though the notes above do not mention 24.05. It makes to me - if it doesn't to you I can try to explain!!

Other opinions welcome too.

Ok I missed the decision where we mentioned the point versions.

Oh! That was always my interpretation. Have I got this wrong?

Sorry. Sounds like something we need to clarify, then!

I never specified point versions before, so this is news to me.

I added a discussion point for next meeting. Unfortunately, I won't be there to defend my pov, as I will be on vacation, but I tried to add details as I see it. https://wiki.koha-community.org/wiki/Documentation_meeting_23_October_2024#Documentation_workflow:_issues_and_ideas

It's too bad we don't have meeting transcripts anymore. I'm looking through meeting notes and there is nothing about the version notes, but I could have sworn we decided on main version only... :/

Were there scripts for transcripts in the old IRC meetings? This must have been before my time.. I'll read through the details and be the advocate for next meeting in your name @carolinecyrlarose :)

Everything in IRC was logged, even the regular chitchat during meetings, not just the notes we tagged with special keywords to add in the minutes. Now, we only have the minutes we write down and anything else we say is lost in the aether. I have a very bad memory, but audio is even worse as I'm a visual person (I now remember your faces rather well, but not necessarily what is said :) ) I may have constructed an audio memory from nothing, but in my head I remember we said we would limit to the main versions to make it simpler.

added 29 commits

• 12394191...82212eb5 - 28 commits from branch koha-community:main
• 8cfde641 - Bug 36665 and Bug 26176 - StaffLoginLibraryBasedOnIP and StaffLoginRestrictLibraryByIP

Compare with previous version

Alright, looks good to me. Rebasing and then merging. Thanks Caroline! :)

Bonjour,

Veuillez noter que je suis en vacances et serai de retour le 11 novembre.

Pour toute question concernant Koha, veuillez ouvrir une demande dans Camelot (https://camelot.inlibro.net/).

Pour les autres questions, je ferai de mon mieux pour répondre à mon retour.

Merci,

Caroline

(Previous comment was accidentally removed, I had written before: A uniform decision was made in today's Documentation Meeting to stay with the main versions and add necessary clarification to the manual. I will take another look at this merge request but that takes care of the discussion of point versions so that won't need to be changed here :) )

Bonjour,

Veuillez noter que je suis en vacances et serai de retour le 11 novembre.

Pour toute question concernant Koha, veuillez ouvrir une demande dans Camelot (https://camelot.inlibro.net/).

Pour les autres questions, je ferai de mon mieux pour répondre à mon retour.

Merci,

Caroline

Bonjour,

Veuillez noter que je suis en vacances et serai de retour le 11 novembre.

Pour toute question concernant Koha, veuillez ouvrir une demande dans Camelot (https://camelot.inlibro.net/).

Pour les autres questions, je ferai de mon mieux pour répondre à mon retour.

Merci,

Caroline

merged

Bonjour,

Veuillez noter que je suis en vacances et serai de retour le 11 novembre.

Pour toute question concernant Koha, veuillez ouvrir une demande dans Camelot (https://camelot.inlibro.net/).

Pour les autres questions, je ferai de mon mieux pour répondre à mon retour.

Merci,

Caroline