• Mark Tompsett's avatar
    Bug 16637: Dependency for C4::Tags not listed · c91b16bd
    Mark Tompsett authored
    Added optional dependency, so as to explain why testing
    explodes when the Enhanced Content system preference
    TagsExternalDictionary is set. It is optional, because not only
    does TagsExternalDictionary have to be set, but TagsEnabled
    must be 'Allow'.
    
    Also tweaked C4/Tags.pm to ignore TagsExternalDictionary,
    if Lingua::Ispell is not installed. A warning is given.
    
    TEST PLAN
    ---------
     1) Set the Enhanced Content system preference
        TagsExternalDictionary to /usr/bin/ispell
    
     2) sudo apt-get install liblingua-ispell-perl
        -- should be a new install
    
     3) prove t/db_dependent/Tags.t
        -- should work fine
    
     4) sudo apt-get remove liblingua-ispell-perl
    
     5) prove t/db_dependent/Tags.t
        -- should explode
    
     6) Clear the Enhanced Content system preference
        TagsExternalDictionary
    
     7) prove t/db_dependent/Tags.t
        -- should work fine
    
     8) apply patch
    
     9) prove t/db_dependent/Tags.t
        -- should work fine
    
    10) Set the Enhanced Content system preference
        TagsExternalDictionary to /usr/bin/ispell
    
    11) prove t/db_dependent/Tags.t
        -- should work, with warning.
    
    12) sudo apt-get install liblingua-ispell-perl
    
    13) prove t/db_dependent/Tags.t
        -- should work fine
    
    14) run koha qa test tools.
    Signed-off-by: 's avatarMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
    Post-hackfest hotel Olympia lobby signoff. Kalimera!
    Works as expected.
    At this moment the Tags.t test does not need the database btw,
    but the module should have much more test coverage.
    Signed-off-by: joubu's avatarJonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: 's avatarKyle M Hall <kyle@bywatersolutions.com>
    c91b16bd
Tags.pm 24 KB