Skip to content

WIP Merge : 63-extending-the-question-notification-system-to-the-follower

Arthur Baribeaud requested to merge 63-extending-the-question-notification-system-to-the-follower into agora

Description

Extends notifications of added answers to all the followers of the question

Migration and compatibility

  • The merge request updates the models, as a consequences, database migrations are needed.
  • The merge request breaks the compatibility.

TODO

Before being accepted, any merge request must fulfill the following requirements:

  • Check PEP8 writing style as described in CONTRIBUTING.md.
  • Ensure existing tests are still working properly.
  • Features have been tested.
  • Every translatable strings are written in proper english.
  • Every translatable strings are tagged for translation using gettext, blocktrans and/or trans.
  • Ensure that there is no side effect in files: changes are only related to one, and only one feature.
  • Ensure that no file has been removed by accident.
  • API is documented, as well as the behavior, if needed, in docs.
  • Ensure the commit history is “clean enough” (this means no extra merge commits, etc).
  • Ensure pipeline succeeds.

Deploy Notes

  • Add the followers in the list of the user who have to be notified when a answer is bring

Steps to Test or Reproduce

To be notified : In the agora of a course, follow a question and add an answer to that question, then look at the notifications. Don't be notified: In the agora of a course, add an answer to a course that is not following, then look at the notifications.

git pull --prune
git checkout agora

Impacted Areas in Application

Reply form Notification system

Merge request reports