Skip to content

Fix/issue 3247

R R requested to merge Regal-Regards/kicad-symbols:fix/issue-3247 into master

This MR fixes the errors described #3247 (closed).

No new errors are introduced in the process of fixing 3247, but some of the symbols previously had errors. Some of the previous errors were fixed, some were not due to a slightly more complicated error.

For instance, the two transmission gate cells had the origin of the transmission gate symbol drawn at (0,0) but the control pin is drawn slightly off-center and triggers the full bounding box origin to shift. How would we prefer to handle this issue?

List of erroneous devices based on KLC S4.1 (fixed are check-marked):

  • 74LVC1G139
  • 74LVC1G27
  • 74LVC1G332
  • 74LVC1G386
  • 74LVC1G66
  • 74LVC2G126
  • 74LVC2G157
  • 74LVC2G53

74LVC1G139 image

KLC status: passed image

74LVC1G27

Note: Also updated footprint filter to pass full KLC check

image

KLC status: passed image

74LVC1G332 image

KLC status: passed image

74LVC1G386 image

KLC status: passed image

74LVC1G66 image

Fixed the snapping of the pin, however, we can always discuss the lack of beauty of this symbol. I think pin4 should have a solder dot on the connectivity towards the the inverted input, cause as of now it's not 100% clear, that pin 4 is the controlling input, or if pin 1 would be the inverting control signal and the analog input.

KLC status: passing S4.1, fails S3.1: image

The S3.1 failure stems from the way the transmission gate was drawn.

image

74LVC2G126 image

KLC status: passing S4.1, fails S3.1 and S5.1: image

I am not sure why it fails S5.1, as it seems to use the same footprint / footprint filtering as the other devices.

Possible to-do: Fix S3.1

74LVC2G157 image

KLC status: passed image

74LVC2G53 image

KLC status: passing S4.1, fails S3.1 image

S3.1 fails due to the nature of the drawing's origin: image

Edited by R R

Merge request reports