Skip to content

Rename existing push switch symbols and add NO/NC variants

KiCad Bot requested to merge github/fork/andrewteasdale/rename_push_switches_add_NO-NC_variant into master

Created by: andrewteasdale

I realise this might be a slightly controversial one. I needed a push switch symbol for high integrity switches such as https://www.mouser.co.uk/datasheet/2/26/APEM_07242018_APEM_IX_Series-1382075.pdf which contain simultaneous normally-open and normally-closed switching pairs.

In creating this symbol, I realised there was some inconsistency in the names used for push switches in the existing library. For example, a generic normally-open push switch is "SW_Push", whereas a generic normally-closed push switch is "SW_Push_Open", a potentially confusing name.

It is my feeling that the abbreviations "NO" for normally-open and "NC" for normally-closed are fairly universally recognised. Therefore I propose changing "SW_Push" to "SW_Push_NO" and SW_Push_Open" to "SW_Push_NC" to reduce potential confusion and make for more consistent naming.

I have changes the existing symbols as follows:

image

In addition, I have added two new symbols for NO/NC switches:

image

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.
Edited by Daniel Giesbrecht

Merge request reports