Skip to content

Fix LM319 'ground' pin type

evanshultz requested to merge github/fork/evanshultz/lm319-lm311-open-emitter into master

I discovered that LM319's Gnd pins were of type Open Emitter. While this isn't totally wrong, it causes an ERC error when connected to ground. That is quite a common use case. LM311, which has a similar output stage, uses Passive type for it's corresponding pin so I switched LM319 pins to that same pin type.

Marking as a bug since this pin types generated a bogus ERC error when the part is used properly in a common way.

Also, I updated the LM311 datasheet link to one that better match the pin names in our symbol.

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Merge request reports