Skip to content

Fix QFN pin mark

Patrick Baus requested to merge PatrickBaus/kicad-packages3D-generator:update_DFN_generator into master

I am currently refactoring the QFN package generator, because I have found quite a lot of DFN/QFN 3D models to be missing or having incorrect names, so I will create a number of MRs over the coming days to keep the changes reviewable.

The first one in the series is a bugfix for the circular pin mark of the QFN generator. Currently, as is, the pin mark is placed on top of the package as can be seen below (example: QFN-16-1EP_4x4mm_Pitch0.65mm). Do note, that I have highlighted the top side of the package to make the pin mark stand out. I am also fully aware that this model does not fit the current naming scheme and the fp_z (first pin indicator depth) parameter is set to 0.1 mm instead of 0.01 mm (This is another error in the yaml file to be fixed later).

QFN_pin_mark

The version currently used in the kicad-packages3D repository looks like this:

QFN_pin_mark_old

In my opinion the latter version is the correct version. This MR fixes the issue mentioned above and also cleans up parts of the source code to adhere to Python formatting standards.

I have not yet updated any models in the kicad-packages3D repository because I think this is best done in one go once I have regenerated all models currently required.

Merge request reports