Skip to content

Fix outline not being recognized due to unit filter not considering unit=1...

Fix outline not being recognized due to unit filter not considering unit=1 rectangles for single-unit symbols

Some parts of the graphic are in unit 1 and others in unit 0, for a single unit symbol.

It will probably fail if the outline rectangle is out of center and if there's a resistor rectangle centered exactly in the center. (I don't care for now)

Reference pull request:  kicad-symbols!4313 (merged)

image.png

Outline rect on unit 1

Rectangle(startx=-22.86, starty=20.32, endx=22.86, endy=-22.86, stroke_width=0.254, stroke_color=None, fill_type='background', fill_color=None, unit=1, demorgan=1)

Rectangle(startx=-4.445, starty=6.858, endx=-1.905, endy=5.842, stroke_width=0.2032, stroke_color=None, fill_type='none', fill_color=None, unit=0, demorgan=1) Rectangle(startx=-4.318, starty=-5.842, endx=-1.778, endy=-6.858, stroke_width=0.2032, stroke_color=None, fill_type='none', fill_color=None, unit=0, demorgan=1) Rectangle(startx=0.127, starty=6.858, endx=2.667, endy=5.842, stroke_width=0.2032, stroke_color=None, fill_type='none', fill_color=None, unit=0, demorgan=1) Rectangle(startx=0.254, starty=-5.842, endx=2.794, endy=-6.858, stroke_width=0.2032, stroke_color=None, fill_type='none', fill_color=None, unit=0, demorgan=1) Rectangle(startx=-22.86, starty=20.32, endx=22.86, endy=-22.86, stroke_width=0.254, stroke_color=None, fill_type='background', fill_color=None, unit=1, demorgan=1) Rectangle(startx=-12.827, starty=-11.811, endx=-7.239, endy=-13.589, stroke_width=0, stroke_color=None, fill_type='none', fill_color=None, unit=1, demorgan=1) Rectangle(startx=-4.445, starty=6.858, endx=-1.905, endy=5.842, stroke_width=0.2032, stroke_color=None, fill_type='none', fill_color=None, unit=0, demorgan=1)

It's an upgraded v7 symbol. I created it from scratch in V7.

Tests performed for this MR

Tested to fix the issue with kicad-symbols!4313 (merged)

Tested with Amplfier_Operational to not create issues on random symbols (I just scrolled through it)

Tested with this modified symbol, it still produces the error message

image.png

Edited by Uli Köhler

Merge request reports