Skip to content

Two terminal chip devices: Error in tolerance calculation

Rene Poeschl requested to merge github/fork/poeschlr/another_fix_for_smd_chip into master

I had a small mistake in the tolerance calculation for multiplications of the TolerancedDimensions class. This resulted in slightly wrong (too small) pads for the SMD two terminal chip devices

More details about the error: I wrote something like new_tolerance = update_tol([old_tolerance]*2) instead of new_tolerance = update_tol([old_tolerance*2]). The first line results in new_tolerance = sqrt(old_tolerance**2 + old_tolerance**2) and the second in the correct new_tolerance = sqrt((2*old_tolerance)**2) = 2*old_tolerance

Edit: re reading ipc shows me my old formular was correct by accident. So no change needed.

Merge request reports