Fix LED 1W 3W
Newer datasheet & small footprint fix
Update the datasheet link to a full english version, hosted on the
Getian's website (the manufacturer).
Fix footprint: set space between pad to 10mm (was ~9.2), just a 0.4mm translation of each pad
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
-
Provide a URL to a datasheet for the footprint(s) you are contributing
- https://www.getiangroup.com/data/upload/ueditor/20190909/5d75f9d95ad18.pdf (white)
- https://www.getiangroup.com/data/upload/20190902/5d6cc52e92386.pdf (colors and rgb variant package)
- http://www.kwalityphotonics.com/images/pdfdocs/ds_47.1_klsl331we.pdf
- http://www.kwalityphotonics.com/images/pdfdocs/ds_47_klhp3433xe.pdf
-
An example screenshot image is very helpful -
If there are matching symbol or 3D model pull requests, provide link(s) as appropriate https://github.com/KiCad/kicad-packages3D/pull/721 https://github.com/KiCad/kicad-symbols/pull/2943 -
Check the output of the Travis automated check scripts - fix any errors as required -
Give a reason behind any intentional library convention rule violation.
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)