Skip to content

TO-92: move F.Fab ref des under part body

evanshultz requested to merge github/fork/evanshultz/to92-refdes into master

Almost all vertical TO-92 footprints didn't have the F.Fab ref des under the part body, going against KLC F5.2.4.a (https://kicad-pcb.org/libraries/klc/F5.2/). This made the assembly layer of the board look rather ugly and confusing because the ref des was floating somewhere outside of the part. So pretty simple fix.

Since this is in violation of KLC I'm marking it as a bug.

Here's an example before and after: image image

I also unrotated pads of these footprints when I noticed them.

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

Merge request reports