Skip to content

Connector_Coaxial: Fix and enhance SMA_Samtec_SMA-J-P-H-ST-EM1_EdgeMount

Otavio Augusto Gomes requested to merge github/fork/gmsotavio/SMA_Samtec_SMA-J-P-H-ST-EM1_EdgeMount into master

I've found some issues with SMA_Samtec_SMA-J-P-H-ST-EM1_EdgeMount.

  • Odd courtyard outline
  • Missing description
  • Improper rotation (KLC F4.2 states: Pin 1 should be located at the top left. Where footprints cannot be oriented with pin 1 in the top-left quadrant, pin 1 should be aligned to the top)
  • The name of the footprint SMA_Samtec_SMA-J-P-H-ST-EM1_EdgeMount is specific. The H refers to plating material (See product catalog http://suddendocs.samtec.com/catalog_english/sma.pdf)

Summary of changes:

Datasheet link (http://suddendocs.samtec.com/prints/sma-j-p-x-st-em1-mkt.pdf)

Before

image

After

image

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Merge request reports