Curved Polys (update)

Clipper does not make it feasible to pass a polygon through and get the related points back, even if you are only doing a boolean operation. All points get scrambled/re-written. So maintaining zones with arcs will require recognizing/converting arcs post-clipper.

Todo:

• Read/write file formats
• Plot arcs as part of polygons
• [x] Convert clipper results to lines/arcs (see SHAPE_LINE_CHAIN::DetectArcs) (Does not work)
• [ ] Integrate DetectArcs to Boolean calculations
• Use Clipper Z value to detect arcs post clipper in boolean operations
• Add unit tests using Simplify to verify that the arcs are not lost and the area not modified
• [ ] Rewrite SHAPE_POLY_SET::Fillet so it creates true arc segments instead of just piecewise linear segments (Not needed as not using in Zone fills)

Stretch tasks:

• [ ] Detect intersections between arcs post Clipper and amend the intersection point (Not needed as not using in Zone fills)

changed the description

mentioned in merge request !375 (closed)

added 19 commits

• 2748b71b...c3c36492 - 10 commits from branch kicad/code:master
• 1cc61565 - ADDED support for reading/writing arcs in polys
• 8869b917 - Removing CLIPPER poly support
• 3a8bd4e2 - Adding conversion from points to arcs
• 4153fbbb - De-scope ClipperLib namespace
• fa4da733 - WIP
• cb3fc551 - Add CIRCLE::Contains( VECTOR2I aP )
• af51dcb4 - Fix Rebase issues
• 76b6b16f - Fix SHAPE_ARC::Collide
• 357e6e2d - Implement SHAPE_LINE_CHAIN::DetectArcs to detect arcs in the chain

Compare with previous version

changed the description

added 1 commit

• cd4b18f7 - Implement SHAPE_LINE_CHAIN::DetectArcs to detect arcs in the chain

Compare with previous version

mentioned in issue #7949 (closed)

changed milestone to %6.0.0-rc1

added pcbnew label

added 115 commits

• cd4b18f7...d9229697 - 107 commits from branch kicad/code:master
• 3b7dd7dd - ADDED support for reading/writing arcs in polys
• 864b33f3 - Removing CLIPPER poly support
• 4792b15f - Adding conversion from points to arcs
• fac38411 - De-scope ClipperLib namespace
• 68dc5038 - WIP
• f9db88a4 - Add CIRCLE::Contains( VECTOR2I aP )
• 825c42ff - Fix Rebase issues
• 77fedb7d - Implement SHAPE_LINE_CHAIN::DetectArcs to detect arcs in the chain

Compare with previous version

changed the description

mentioned in issue #5409 (closed)

It might be good to consider pulling out the underlying code to plot arcs to a separate MR that can be merged now, as plotting real arcs is blocking using real arcs for collision-testing in the DRC (right now we collision test using arc approximations, which causes behavior like #6681 (comment 550250755) )

added 1 commit

• 1462248d - Add qa test for SHAPE_LINE_CHAIN::DetectArcs

Compare with previous version

added 605 commits

• 1462248d...d7e44b51 - 596 commits from branch kicad/code:master
• fef21e0a - ADDED support for reading/writing arcs in polys
• 9f8fb433 - Removing CLIPPER poly support
• 0a11b2c9 - Adding conversion from points to arcs
• 5b87965c - De-scope ClipperLib namespace
• 002643fb - WIP
• c7af6fe2 - Add CIRCLE::Contains( VECTOR2I aP )
• d716d21d - Fix Rebase issues
• 536680a2 - Implement SHAPE_LINE_CHAIN::DetectArcs to detect arcs in the chain
• 63f6b44e - Add qa test for SHAPE_LINE_CHAIN::DetectArcs

Compare with previous version

added 1 commit

• 9e27136d - Cleanup function comments in CIRCLE

Compare with previous version

added 2 commits

• fb2c23fe - SHAPE_POLY_SET: Detect arcs after boolean operations
• f4b88399 - Add qa test for SHAPE_POLY_SET::Simplify()

Compare with previous version

added 2 commits

• ff8d045b - Add qa test for SHAPE_POLY_SET::Simplify()
• 62731afb - Refactor SHAPE_LINE_CHAIN to allow two shapes per point

Compare with previous version

added 2 commits

• 7bc1d304 - SHAPE_LINE_CHAIN::Area() should always be positive
• 198d1062 - WIP SplitArc

Compare with previous version

added 3 commits

• 8a3cd48a - Refactor SHAPE_LINE_CHAIN to allow two shapes per point
• e07de859 - SHAPE_LINE_CHAIN::Area() should always be positive
• afe5711c - WIP SplitArc

Compare with previous version