Skip to content

Fix crashing to do CloseProject() calling PlayersClose twice

Mark Roszko requested to merge mroszko/kicad:close-project-crash into master

This is the immediate fix to #5164 (closed).

The reality is the CloseProject() MR didn't fix/handle the kiway interaction. Closed frames do not clear their references in kiway m_playerFrameName because it was previously assumed kicad itself was closing. Calling CloseProject here duplicated the PlayersClose call which led to this crash.

I may be able to better handle frame closure in my other MR !305 (merged) as I was refactoring window closing there.

@craftyjon

Edited by Mark Roszko

Merge request reports